chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc ('k') | chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc » ('j') | chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

index 860356924fd82d2f40d497725c1de559bbff5a55..877b0c74d21247279e464368858defebd60e6024 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc

@@ -995,7 +995,7 @@ class V1App : public TestBrowserWindow {

gfx::Rect(10, 10, 20, 30));

Browser::CreateParams params = Browser::CreateParams::CreateForApp(

kCrxAppPrefix + app_name, true /* trusted_source */, gfx::Rect(),

- profile);

+ profile, true);

params.window = this;

browser_.reset(new Browser(params));

chrome::AddTabAt(browser_.get(), GURL(), 0, true);

@@ -2314,7 +2314,7 @@ TEST_F(MultiProfileMultiBrowserShelfLayoutChromeLauncherControllerImplTest,

multi_user_util::GetAccountIdFromProfile(profile());

// Create a browser window with a native window for the current user.

- Browser::CreateParams params(profile());

+ Browser::CreateParams params(profile(), true);

std::unique_ptr<Browser> browser(

chrome::CreateBrowserWithAuraTestWindowForParams(nullptr, &params));

BrowserWindow* browser_window = browser->window();