Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: chrome/browser/ssl/security_state_tab_helper_browser_tests.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
diff --git a/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc b/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
index d03cbd941f1bb40500386759d8ec46ddff5fda3e..a22181b034c1993bf7f01fe6b10b048ab211521f 100644
--- a/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
+++ b/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
@@ -1289,7 +1289,7 @@ void CheckForOneFutureHttpWarningConsoleMessage(
IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,
ConsoleMessage) {
ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(
- Browser::CreateParams(browser()->profile()));
+ Browser::CreateParams(browser()->profile(), true));
content::WebContents* original_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::WebContents* contents =
@@ -1359,7 +1359,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTest, ConsoleMessage) {
ASSERT_TRUE(embedded_test_server()->Start());
host_resolver()->AddRule("*", embedded_test_server()->GetURL("/").host());
ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(
- Browser::CreateParams(browser()->profile()));
+ Browser::CreateParams(browser()->profile(), true));
content::WebContents* original_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::WebContents* contents =
@@ -1448,7 +1448,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTest, ConsoleMessage) {
IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,
ConsoleMessageNotPrintedForFrameNavigation) {
ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(
- Browser::CreateParams(browser()->profile()));
+ Browser::CreateParams(browser()->profile(), true));
content::WebContents* original_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::WebContents* contents =
@@ -1529,7 +1529,7 @@ IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,
IN_PROC_BROWSER_TEST_F(SecurityStateTabHelperTestWithPasswordCcSwitch,
ConsoleMessageNotPrintedForPushStateNavigation) {
ConsoleWebContentsDelegate* delegate = new ConsoleWebContentsDelegate(
- Browser::CreateParams(browser()->profile()));
+ Browser::CreateParams(browser()->profile(), true));
content::WebContents* original_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::WebContents* contents =

Powered by Google App Engine
This is Rietveld 408576698