chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api_unittest.cc ('k') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('j') | chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

diff --git a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

index 434f1bd21154c50d03dcd18e287c56086d72c3d5..240e4494574255bc56056c7e4474762f4ac216c1 100644

--- a/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

+++ b/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc

@@ -258,7 +258,7 @@ void ChromeRuntimeAPIDelegate::OpenURL(const GURL& uninstall_url) {

Profile* profile = Profile::FromBrowserContext(browser_context_);

Browser* browser = chrome::FindLastActiveWithProfile(profile);

if (!browser)

- browser = new Browser(Browser::CreateParams(profile));

+ browser = new Browser(Browser::CreateParams(profile, false));

chrome::NavigateParams params(

browser, uninstall_url, ui::PAGE_TRANSITION_CLIENT_REDIRECT);