Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)
Patch Set: rebase to tot Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 325a624ccd3117180d35600e0ee71221ad86fee8..e265b81041ef52932f0e0e06b8809fe576f6e04e 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -598,6 +598,7 @@ ExtensionFunction::ResponseAction WindowsCreateFunction::Run() {
false /* trusted_source */, window_bounds, window_profile);
}
create_params.initial_show_state = ui::SHOW_STATE_NORMAL;
+ create_params.user_gesture = user_gesture();
if (create_data && create_data->state) {
create_params.initial_show_state =
ConvertToWindowShowState(create_data->state);
@@ -1004,7 +1005,7 @@ ExtensionFunction::ResponseAction TabsCreateFunction::Run() {
std::string error;
std::unique_ptr<base::DictionaryValue> result(
- ExtensionTabUtil::OpenTab(this, options, &error));
+ ExtensionTabUtil::OpenTab(this, options, user_gesture(), &error));
if (!result)
return RespondNow(Error(error));

Powered by Google App Engine
This is Rietveld 408576698