chrome/browser/ui/views/frame/browser_window_factory.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/browser_window_factory.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: Rebase to ToT Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/frame/browser_frame.h"	5 #include "chrome/browser/ui/views/frame/browser_frame.h"

6 #include "chrome/browser/ui/views/frame/browser_view.h"	6 #include "chrome/browser/ui/views/frame/browser_view.h"

7 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"	7 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"

8 #include "chrome/grit/chromium_strings.h"	8 #include "chrome/grit/chromium_strings.h"

	9 #include "ui/aura/client/aura_constants.h"

	10 #include "ui/aura/window.h"

9 #include "ui/base/l10n/l10n_util.h"	11 #include "ui/base/l10n/l10n_util.h"

10 #include "ui/views/widget/widget.h"	12 #include "ui/views/widget/widget.h"

11	13

12 // static	14 // static

13 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {	15 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser,

	16 bool user_gesture) {

14 // Create the view and the frame. The frame will attach itself via the view	17 // Create the view and the frame. The frame will attach itself via the view

15 // so we don't need to do anything with the pointer.	18 // so we don't need to do anything with the pointer.

16 BrowserView* view = new BrowserView();	19 BrowserView* view = new BrowserView();

17 view->Init(browser);	20 view->Init(browser);

18 (new BrowserFrame(view))->InitBrowserFrame();	21 (new BrowserFrame(view))->InitBrowserFrame();

19 view->GetWidget()->non_client_view()->SetAccessibleName(	22 view->GetWidget()->non_client_view()->SetAccessibleName(

20 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));	23 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));

	24 // For now, all browser windows are true.

	25 view->GetWidget()->GetNativeWindow()->SetProperty(

	26 aura::client::kCreatedByUserGesture, user_gesture);

21 return view;	27 return view;

22 }	28 }

OLD	NEW