ash: fix regression where ctrl+n put new window on wrong desktop

chrome/browser/ui/extensions/application_launch.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/application_launch.h"
 
 #include <string>
 
 #include "apps/launcher.h"
 #include "base/macros.h"
@@ skipping 176 matching lines @@
   gfx::Rect initial_bounds;
   if (!params.override_bounds.IsEmpty()) {
     initial_bounds = params.override_bounds;
   } else if (extension) {
     initial_bounds.set_width(
         extensions::AppLaunchInfo::GetLaunchWidth(extension));
     initial_bounds.set_height(
         extensions::AppLaunchInfo::GetLaunchHeight(extension));
   }
 
+  // TODO(erg): AppLaunchParams should pass through the user_gesture from the
+  // extension system here.
   Browser::CreateParams browser_params(Browser::CreateParams::CreateForApp(
-      app_name, true /* trusted_source */, initial_bounds, profile));
+      app_name, true /* trusted_source */, initial_bounds, profile, true));
 
   browser_params.initial_show_state = DetermineWindowShowState(profile,
                                                                params.container,
                                                                extension);
 
   Browser* browser = new Browser(browser_params);
   ui::PageTransition transition =
       (extension ? ui::PAGE_TRANSITION_AUTO_BOOKMARK
                  : ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
 
@@ skipping 14 matching lines @@
                            const GURL& url) {
   const Extension* extension = GetExtension(launch_params);
   CHECK(extension);
   Profile* const profile = launch_params.profile;
   WindowOpenDisposition disposition = launch_params.disposition;
 
   Browser* browser = chrome::FindTabbedBrowser(profile, false);
   WebContents* contents = NULL;
   if (!browser) {
     // No browser for this profile, need to open a new one.
-    browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
+    //
+    // TODO(erg): AppLaunchParams should pass user_gesture from the extension
+    // system to here.
+    browser =
+        new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile, true));
     browser->window()->Show();
     // There's no current tab in this browser window, so add a new one.
     disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
   } else {
     // For existing browser, ensure its window is shown and activated.
     browser->window()->Show();
     browser->window()->Activate();
   }
 
   extensions::LaunchType launch_type =
@@ skipping 165 matching lines @@
   extensions::TabHelper::FromWebContents(tab)->UpdateShortcutOnLoadComplete();
 
   return tab;
 }
 
 bool CanLaunchViaEvent(const extensions::Extension* extension) {
   const extensions::Feature* feature =
       extensions::FeatureProvider::GetAPIFeature("app.runtime");
   return feature && feature->IsAvailableToExtension(extension).is_available();
 }