ash: fix regression where ctrl+n put new window on wrong desktop

chrome/browser/ui/webui/chrome_web_contents_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chrome_web_contents_handler.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
@@ skipping 21 matching lines @@
     content::BrowserContext* context,
     WebContents* source,
     const OpenURLParams& params) {
   if (!context)
     return NULL;
 
   Profile* profile = Profile::FromBrowserContext(context);
 
   Browser* browser = chrome::FindTabbedBrowser(profile, false);
   const bool browser_created = !browser;
-  if (!browser)
-    browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
+  if (!browser) {
+    // TODO(erg): OpenURLParams should pass a user_gesture flag, pass it to
+    // CreateParams, and pass the real value to nav_params below.
+    browser =
+        new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile, true));
+  }
   chrome::NavigateParams nav_params(browser, params.url, params.transition);
   nav_params.referrer = params.referrer;
   if (source && source->IsCrashed() &&
       params.disposition == WindowOpenDisposition::CURRENT_TAB &&
       ui::PageTransitionCoreTypeIs(params.transition,
                                    ui::PAGE_TRANSITION_LINK)) {
     nav_params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
   } else {
     nav_params.disposition = params.disposition;
   }
@@ skipping 21 matching lines @@
     WindowOpenDisposition disposition,
     const gfx::Rect& initial_rect,
     bool user_gesture) {
   if (!context)
     return;
 
   Profile* profile = Profile::FromBrowserContext(context);
 
   Browser* browser = chrome::FindTabbedBrowser(profile, false);
   const bool browser_created = !browser;
-  if (!browser)
-    browser = new Browser(Browser::CreateParams(Browser::TYPE_TABBED, profile));
+  if (!browser) {
+    browser = new Browser(
+        Browser::CreateParams(Browser::TYPE_TABBED, profile, user_gesture));
+  }
   chrome::NavigateParams params(browser, new_contents);
   params.source_contents = source;
   params.disposition = disposition;
   params.window_bounds = initial_rect;
   params.window_action = chrome::NavigateParams::SHOW_WINDOW;
-  params.user_gesture = true;
+  params.user_gesture = user_gesture;
   chrome::Navigate(&params);
 
   // Close the browser if chrome::Navigate created a new one.
   if (browser_created && (browser != params.browser))
     browser->window()->Close();
 }