chrome/browser/ui/cocoa/test/cocoa_profile_test.mm - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/test/cocoa_profile_test.mm

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/browser.h ('K') | « chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h"	5 #include "chrome/browser/ui/cocoa/test/cocoa_profile_test.h"

6	6

7 #include "base/run_loop.h"	7 #include "base/run_loop.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"	9 #include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"

10 #include "chrome/browser/bookmarks/bookmark_model_factory.h"	10 #include "chrome/browser/bookmarks/bookmark_model_factory.h"

(...skipping 76 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87 void CocoaProfileTest::CloseBrowserWindow() {	87 void CocoaProfileTest::CloseBrowserWindow() {

88 // Check to make sure a window was actually created.	88 // Check to make sure a window was actually created.

89 DCHECK(browser_->window());	89 DCHECK(browser_->window());

90 browser_->tab_strip_model()->CloseAllTabs();	90 browser_->tab_strip_model()->CloseAllTabs();

91 chrome::CloseWindow(browser_.get());	91 chrome::CloseWindow(browser_.get());

92 // \|browser_\| will be deleted by its BrowserWindowController.	92 // \|browser_\| will be deleted by its BrowserWindowController.

93 ignore_result(browser_.release());	93 ignore_result(browser_.release());

94 }	94 }

95	95

96 Browser* CocoaProfileTest::CreateBrowser() {	96 Browser* CocoaProfileTest::CreateBrowser() {

97 return new Browser(Browser::CreateParams(profile()));	97 return new Browser(Browser::CreateParams(profile(), true));

98 }	98 }

OLD	NEW