chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc - Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.cc

Issue 2685333005: ash: fix regression where ctrl+n put new window on wrong desktop (Closed)

Patch Set: We have both kinds of compile fixes: mac and windows Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc ('K') | « chrome/browser/ui/ash/window_positioner_unittest.cc ('k') | chrome/browser/ui/browser.h » ('j') | chrome/browser/ui/browser.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"	5 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"

6	6

7 #include "chrome/browser/signin/signin_promo.h"	7 #include "chrome/browser/signin/signin_promo.h"

8 #include "chrome/browser/ui/browser.h"	8 #include "chrome/browser/ui/browser.h"

9 #include "chrome/browser/ui/browser_finder.h"	9 #include "chrome/browser/ui/browser_finder.h"

10 #include "chrome/browser/ui/browser_list.h"	10 #include "chrome/browser/ui/browser_list.h"

(...skipping 20 matching lines...) Expand all Loading...
31 void BookmarkBubbleSignInDelegate::OnBrowserRemoved(Browser* browser) {	31 void BookmarkBubbleSignInDelegate::OnBrowserRemoved(Browser* browser) {

32 if (browser == browser_)	32 if (browser == browser_)

33 browser_ = NULL;	33 browser_ = NULL;

34 }	34 }

35	35

36 void BookmarkBubbleSignInDelegate::EnsureBrowser() {	36 void BookmarkBubbleSignInDelegate::EnsureBrowser() {

37 if (!browser_) {	37 if (!browser_) {

38 Profile* original_profile = profile_->GetOriginalProfile();	38 Profile* original_profile = profile_->GetOriginalProfile();

39 browser_ = chrome::FindLastActiveWithProfile(original_profile);	39 browser_ = chrome::FindLastActiveWithProfile(original_profile);

40 if (!browser_) {	40 if (!browser_) {

41 browser_ = new Browser(Browser::CreateParams(original_profile));	41 browser_ = new Browser(Browser::CreateParams(original_profile, true));

42 }	42 }

43 }	43 }

44 }	44 }

OLD	NEW