ash: fix regression where ctrl+n put new window on wrong desktop

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 168 matching lines @@
     // The bounds of the window to open.
     gfx::Rect initial_bounds;
 
     // The workspace the window should open in, if the platform supports it.
     std::string initial_workspace;
 
     ui::WindowShowState initial_show_state;
 
     bool is_session_restore;
 
+    // Whether this browser was created by a user gesture.

[Mr4D (OOO till 08-26), 2017/02/13 23:57:39]

Please add a comment towards why this is&needed - not a repetition of the name.

[Elliot Glaysher, 2017/02/15 22:15:02]

Done.

+    bool user_gesture;

[Mr4D (OOO till 08-26), 2017/02/13 23:57:39]

The name "user_gesture" suggests that there must have been touch used. That is
rather confusing.

How about "user_action" - or "user_activation"?

[Elliot Glaysher, 2017/02/15 22:15:02]

I disagree. The name "user_gesture" predates touch support entirely, and has
always referred to an event caused by user input, whether keyboard or mouse (or
when we added touch support, touch).

$ git grep user_gesture | wc -l
1078

+
     // Supply a custom BrowserWindow implementation, to be used instead of the
     // default. Intended for testing.
     BrowserWindow* window;
 
    private:
     friend class Browser;
 
     // The application name that is also the name of the window to the shell.
     // Do not set this value directly, use CreateForApp.
     // This name will be set for:
@@ skipping 818 matching lines @@
   // The following factory is used for chrome update coalescing.
   base::WeakPtrFactory<Browser> chrome_updater_factory_;
 
   // The following factory is used to close the frame at a later time.
   base::WeakPtrFactory<Browser> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_