Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 268533002: Fix a findbugs error in Addr2LineWorkerPool.java. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fix a findbugs error in Addr2LineWorkerPool.java. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267664

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M tools/binary_size/java/src/org/chromium/tools/binary_size/Addr2LineWorkerPool.java View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
+bulach since Andrew is not a full committer just yet.
6 years, 7 months ago (2014-04-30 21:37:15 UTC) #1
bulach
lgtm, thanks!
6 years, 7 months ago (2014-05-01 10:26:14 UTC) #2
Andrew Hayden (chromium.org)
Hopefully all that code will be dead soon, but thank you for patching! LGTM.
6 years, 7 months ago (2014-05-01 12:43:12 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-01 18:42:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/268533002/1
6 years, 7 months ago (2014-05-01 18:43:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 19:17:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium
6 years, 7 months ago (2014-05-01 19:17:24 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-01 19:32:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/268533002/20001
6 years, 7 months ago (2014-05-01 19:33:26 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 23:36:57 UTC) #10
Message was sent while issue was closed. 
Change committed as 267664

Powered by Google App Engine
This is Rietveld 408576698