Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2685303002: Significantly reduce the timeout app_jit is given on the buildbot (Closed)

Created:
3 years, 10 months ago by kustermann
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, rmacnak
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Significantly reduce the timeout app_jit is given on the buildbot Currently tests in the app_jit-debug configuration are given 16 minutes timeout. This caused us to run into a global timeout of test.dart (it's "debug timer" which is set to 10 minutes of inactivity). Even the slowest tests run in the app_jit-debug configuration within around 1:30 m on the buildbot. This CL changes the timeout from 16 minutes to 4 minutes. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/be2942a279c96ae3e899754601f2fcde8aba16d7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/testing/dart/compiler_configuration.dart View 1 chunk +2 lines, -2 lines 1 comment Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kustermann
3 years, 10 months ago (2017-02-10 11:42:31 UTC) #2
kustermann
https://codereview.chromium.org/2685303002/diff/1/tools/testing/dart/compiler_configuration.dart File tools/testing/dart/compiler_configuration.dart (right): https://codereview.chromium.org/2685303002/diff/1/tools/testing/dart/compiler_configuration.dart#newcode795 tools/testing/dart/compiler_configuration.dart:795: return multiplier; The returned value is applied again with ...
3 years, 10 months ago (2017-02-10 11:43:46 UTC) #3
Vyacheslav Egorov (Google)
lgtm
3 years, 10 months ago (2017-02-10 11:55:49 UTC) #4
kustermann
Committed patchset #1 (id:1) manually as be2942a279c96ae3e899754601f2fcde8aba16d7 (presubmit successful).
3 years, 10 months ago (2017-02-10 11:56:52 UTC) #6
rmacnak
3 years, 10 months ago (2017-02-11 01:03:12 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698