Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 26853002: Removing extraneous pymod_do_main directory from gyp_chromium. (Closed)

Created:
7 years, 2 months ago by Stephen Chennney
Modified:
7 years, 1 month ago
Reviewers:
adamk, abarth-chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Removing extraneous pymod_do_main directory from gyp_chromium. R=abarth@chromium.org, adamk@chromium.org BUG=297477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232189

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M build/gyp_chromium View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Stephen Chennney
7 years, 2 months ago (2013-10-10 14:49:04 UTC) #1
Stephen Chennney
DO NOT land this until the Chromium then Blink changes have landed.
7 years, 2 months ago (2013-10-10 14:49:40 UTC) #2
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-10 14:55:24 UTC) #3
Stephen Chennney
Wait until Blink rolls past r159347 in Chromium before committing.
7 years, 2 months ago (2013-10-10 16:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/26853002/1
7 years, 2 months ago (2013-10-16 17:42:31 UTC) #5
commit-bot: I haz the power
Failed to apply patch for build/gyp_chromium: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-16 17:42:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/26853002/8001
7 years, 2 months ago (2013-10-16 17:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/26853002/8001
7 years, 2 months ago (2013-10-16 20:45:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/26853002/8001
7 years, 2 months ago (2013-10-16 21:37:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/26853002/8001
7 years, 2 months ago (2013-10-17 01:44:45 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 02:29:59 UTC) #11
Stephen Chennney
7 years, 1 month ago (2013-10-31 19:53:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 manually as r232189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698