Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/secondary/third_party/crashpad/crashpad/util/BUILD.gn

Issue 2685233002: Update mig.py to take an explicit sdk argument. (Closed)
Patch Set: Comments from mark. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/crashpad/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
diff --git a/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn b/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
index ff7907107216f4f81a708dffa2733f200e85563d..99580a5f8ef7943b13216be4ccadcaa4ca44e7eb 100644
--- a/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
+++ b/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn
@@ -35,8 +35,15 @@ if (is_mac) {
args = [ "{{source}}" ]
args += rebase_path(outputs, root_build_dir)
if (!use_system_xcode) {
- args += [ hermetic_xcode_path ]
+ args += [
+ "--developer-dir",
+ hermetic_xcode_path,
+ ]
}
+ args += [
+ "--sdk",
+ mac_sdk_path,
+ ]
}
}
« no previous file with comments | « no previous file | third_party/crashpad/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698