Issue 26852004: Have NodeRareData's ensureNodeLists() / ensureMutationObserverData() return a reference

Issue 26852004: Have NodeRareData's ensureNodeLists() / ensureMutationObserverData() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have NodeRareData's ensureNodeLists() / ensureMutationObserverData() return a reference Have NodeRareData's ensureNodeLists() / ensureMutationObserverData() return a reference instead of a pointer as the return value can never be null. This makes the calling code look safer. R=adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160213

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -23 lines)			Patch
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/dom/NodeRareData.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/LabelableElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26852004/1

7 years, 2 months ago (2013-10-21 18:17:31 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=12783

7 years, 2 months ago (2013-10-21 20:30:11 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26852004/1

7 years, 2 months ago (2013-10-22 13:21:35 UTC) #6

Message was sent while issue was closed.

Change committed as 160213

Expand Messages | Collapse Messages