components/favicon/core/BUILD.gn - Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/BUILD.gn

Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)

Patch Set: Peter's comments #2 (WIP) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/BUILD.gn

diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn

index 7d8c060d96ae2798e638b92757a12f48ec75de2d..a9b7955d876f69b51ba904bbb6df4eb220d65754 100644

--- a/components/favicon/core/BUILD.gn

+++ b/components/favicon/core/BUILD.gn

@@ -22,6 +22,8 @@ static_library("core") {

"favicon_url.h",

"favicon_util.cc",

"favicon_util.h",

+ "features.cc",

+ "features.h",

"large_icon_service.cc",

"large_icon_service.h",

]