Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

Issue 2685173002: Extend LargeIconService to fetch missing favicons from a Google server (Closed)
Patch Set: Peter's comments #2 (WIP) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/favicon_base/favicon_types.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h" 5 #include "ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "base/threading/sequenced_worker_pool.h" 9 #include "base/threading/sequenced_worker_pool.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
11 #include "components/favicon/core/large_icon_service.h" 11 #include "components/favicon/core/large_icon_service.h"
12 #include "components/image_fetcher/image_fetcher_impl.h"
12 #include "components/keyed_service/core/service_access_type.h" 13 #include "components/keyed_service/core/service_access_type.h"
13 #include "components/keyed_service/ios/browser_state_dependency_manager.h" 14 #include "components/keyed_service/ios/browser_state_dependency_manager.h"
14 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h" 15 #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"
15 #include "ios/chrome/browser/browser_state/chrome_browser_state.h" 16 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
16 #include "ios/chrome/browser/favicon/favicon_service_factory.h" 17 #include "ios/chrome/browser/favicon/favicon_service_factory.h"
18 #include "ios/chrome/browser/suggestions/ios_image_decoder_impl.h"
17 #include "ios/web/public/web_thread.h" 19 #include "ios/web/public/web_thread.h"
18 20
19 // static 21 // static
20 favicon::LargeIconService* IOSChromeLargeIconServiceFactory::GetForBrowserState( 22 favicon::LargeIconService* IOSChromeLargeIconServiceFactory::GetForBrowserState(
21 ios::ChromeBrowserState* browser_state) { 23 ios::ChromeBrowserState* browser_state) {
22 return static_cast<favicon::LargeIconService*>( 24 return static_cast<favicon::LargeIconService*>(
23 GetInstance()->GetServiceForBrowserState(browser_state, true)); 25 GetInstance()->GetServiceForBrowserState(browser_state, true));
24 } 26 }
25 27
26 // static 28 // static
(...skipping 13 matching lines...) Expand all
40 42
41 std::unique_ptr<KeyedService> 43 std::unique_ptr<KeyedService>
42 IOSChromeLargeIconServiceFactory::BuildServiceInstanceFor( 44 IOSChromeLargeIconServiceFactory::BuildServiceInstanceFor(
43 web::BrowserState* context) const { 45 web::BrowserState* context) const {
44 ios::ChromeBrowserState* browser_state = 46 ios::ChromeBrowserState* browser_state =
45 ios::ChromeBrowserState::FromBrowserState(context); 47 ios::ChromeBrowserState::FromBrowserState(context);
46 48
47 return base::MakeUnique<favicon::LargeIconService>( 49 return base::MakeUnique<favicon::LargeIconService>(
48 ios::FaviconServiceFactory::GetForBrowserState( 50 ios::FaviconServiceFactory::GetForBrowserState(
49 browser_state, ServiceAccessType::EXPLICIT_ACCESS), 51 browser_state, ServiceAccessType::EXPLICIT_ACCESS),
50 web::WebThread::GetBlockingPool()); 52 web::WebThread::GetBlockingPool(),
53 base::MakeUnique<image_fetcher::ImageFetcherImpl>(
54 base::MakeUnique<suggestions::IOSImageDecoderImpl>(),
55 browser_state->GetRequestContext()));
51 } 56 }
52 57
53 web::BrowserState* IOSChromeLargeIconServiceFactory::GetBrowserStateToUse( 58 web::BrowserState* IOSChromeLargeIconServiceFactory::GetBrowserStateToUse(
54 web::BrowserState* context) const { 59 web::BrowserState* context) const {
55 return GetBrowserStateOwnInstanceInIncognito(context); 60 return GetBrowserStateOwnInstanceInIncognito(context);
56 } 61 }
57 62
58 bool IOSChromeLargeIconServiceFactory::ServiceIsNULLWhileTesting() const { 63 bool IOSChromeLargeIconServiceFactory::ServiceIsNULLWhileTesting() const {
59 return true; 64 return true;
60 } 65 }
OLDNEW
« no previous file with comments | « components/favicon_base/favicon_types.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698