Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: src/inspector/v8-debugger.h

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added comment about inlined jsframe index Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | src/inspector/v8-debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.h
diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h
index c45c76f7f922a33f05052f4bfa7f53e1bb0fc83d..a4518aac20a74a2e5847163cae8bf1e65903e536 100644
--- a/src/inspector/v8-debugger.h
+++ b/src/inspector/v8-debugger.h
@@ -33,9 +33,6 @@ class V8Debugger : public v8::debug::DebugDelegate {
bool enabled() const;
- String16 setBreakpoint(const ScriptBreakpoint&, int* actualLineNumber,
- int* actualColumnNumber);
- void removeBreakpoint(const String16& breakpointId);
void setBreakpointsActivated(bool);
bool breakpointsActivated() const { return m_breakpointsActivated; }
@@ -101,17 +98,15 @@ class V8Debugger : public v8::debug::DebugDelegate {
v8::Local<v8::Value> argv[],
bool catchExceptions);
v8::Local<v8::Context> debuggerContext() const;
- void clearBreakpoints();
static void v8OOMCallback(void* data);
static void breakProgramCallback(const v8::FunctionCallbackInfo<v8::Value>&);
- void handleProgramBreak(v8::Local<v8::Context> pausedContext,
- v8::Local<v8::Object> executionState,
- v8::Local<v8::Value> exception,
- v8::Local<v8::Array> hitBreakpoints,
- bool isPromiseRejection = false,
- bool isUncaught = false);
+ void handleProgramBreak(
+ v8::Local<v8::Context> pausedContext,
+ v8::Local<v8::Object> executionState, v8::Local<v8::Value> exception,
+ const v8::PersistentValueVector<v8::debug::BreakPoint>& hitBreakpoints,
+ bool isPromiseRejection = false, bool isUncaught = false);
enum ScopeTargetKind {
FUNCTION,
« no previous file with comments | « src/inspector/debugger_script_externs.js ('k') | src/inspector/v8-debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698