Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/inspector/v8-debugger-script.cc

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added comment about inlined jsframe index Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-script.cc
diff --git a/src/inspector/v8-debugger-script.cc b/src/inspector/v8-debugger-script.cc
index 200cdc71a26da41ae8bba76d30144ad5a2eca0f7..c7700d814b9a86e63192b58e584abf2299db0b7b 100644
--- a/src/inspector/v8-debugger-script.cc
+++ b/src/inspector/v8-debugger-script.cc
@@ -184,6 +184,10 @@ class ActualScript : public V8DebuggerScript {
}
private:
+ v8::Local<v8::debug::Script> script() override {
+ return m_script.Get(m_isolate);
+ }
+
String16 GetNameOrSourceUrl(v8::Local<v8::debug::Script> script) {
v8::Local<v8::String> name;
if (script->Name().ToLocal(&name) || script->SourceURL().ToLocal(&name))
@@ -259,6 +263,10 @@ class WasmVirtualScript : public V8DebuggerScript {
void resetBlackboxedStateCache() override {}
private:
+ v8::Local<v8::debug::Script> script() override {
+ return m_script.Get(m_isolate);
+ }
+
static const String16& emptyString() {
static const String16 singleEmptyString;
return singleEmptyString;
@@ -306,4 +314,10 @@ void V8DebuggerScript::setSourceURL(const String16& sourceURL) {
m_sourceURL = sourceURL;
}
+v8::debug::Location V8DebuggerScript::setBreakpoint(
+ const v8::debug::Location& location,
+ v8::Local<v8::debug::BreakPoint> breakPoint) {
+ return script()->SetBreakPoint(location, breakPoint);
+}
+
} // namespace v8_inspector
« no previous file with comments | « src/inspector/v8-debugger-script.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698