Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/inspector/v8-debugger-agent-impl.h

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added comment about inlined jsframe index Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-agent-impl.h
diff --git a/src/inspector/v8-debugger-agent-impl.h b/src/inspector/v8-debugger-agent-impl.h
index 41a18a8d3688e2da939d6928b6e95cb567d4f25b..61b379578ed7a2e21748fd8babf9cde8e24aa08f 100644
--- a/src/inspector/v8-debugger-agent-impl.h
+++ b/src/inspector/v8-debugger-agent-impl.h
@@ -8,7 +8,7 @@
#include <vector>
#include "src/base/macros.h"
-#include "src/debug/interface-types.h"
+#include "src/debug/debug-interface.h"
#include "src/inspector/java-script-call-frame.h"
#include "src/inspector/protocol/Debugger.h"
#include "src/inspector/protocol/Forward.h"
@@ -127,9 +127,10 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
void reset();
// Interface for V8InspectorImpl
- void didPause(int contextId, v8::Local<v8::Value> exception,
- const std::vector<String16>& hitBreakpoints,
- bool isPromiseRejection, bool isUncaught, bool isOOMBreak);
+ void didPause(
+ int contextId, v8::Local<v8::Value> exception,
+ const v8::PersistentValueVector<v8::debug::BreakPoint>& hitBreakpoints,
+ bool isPromiseRejection, bool isUncaught, bool isOOMBreak);
void didContinue();
void didParseSource(std::unique_ptr<V8DebuggerScript>, bool success);
void willExecuteScript(int scriptId);
@@ -161,9 +162,6 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
void removeBreakpointImpl(const String16& breakpointId);
void clearBreakDetails();
- void internalSetAsyncCallStackDepth(int);
- void increaseCachedSkipStackGeneration();
-
Response setBlackboxPattern(const String16& pattern);
void resetBlackboxedStateCache();
@@ -171,11 +169,11 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
using ScriptsMap =
protocol::HashMap<String16, std::unique_ptr<V8DebuggerScript>>;
- using BreakpointIdToDebuggerBreakpointIdsMap =
- protocol::HashMap<String16, std::vector<String16>>;
- using DebugServerBreakpointToBreakpointIdAndSourceMap =
- protocol::HashMap<String16, std::pair<String16, BreakpointSource>>;
- using MuteBreakpoins = protocol::HashMap<String16, std::pair<String16, int>>;
+
+ using BreakpointIdToBreakpoints =
+ protocol::HashMap<String16,
+ std::vector<v8::Global<v8::debug::BreakPoint>>>;
+ using BreakpointIdToSource = protocol::HashMap<String16, BreakpointSource>;
enum DebuggerStep { NoStep = 0, StepInto, StepOver, StepOut };
@@ -188,9 +186,11 @@ class V8DebuggerAgentImpl : public protocol::Debugger::Backend {
v8::Isolate* m_isolate;
JavaScriptCallFrames m_pausedCallFrames;
ScriptsMap m_scripts;
- BreakpointIdToDebuggerBreakpointIdsMap m_breakpointIdToDebuggerBreakpointIds;
- DebugServerBreakpointToBreakpointIdAndSourceMap m_serverBreakpoints;
- String16 m_continueToLocationBreakpointId;
+
+ BreakpointIdToBreakpoints m_idToBreakpoints;
+ BreakpointIdToSource m_breakpointIdToSource;
+
+ v8::Global<v8::debug::BreakPoint> m_continueToLocationBreakpoint;
using BreakReason =
std::pair<String16, std::unique_ptr<protocol::DictionaryValue>>;
« no previous file with comments | « src/inspector/v8-debugger.cc ('k') | src/inspector/v8-debugger-agent-impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698