Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: src/inspector/debugger-script.js

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added comment about inlined jsframe index Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/factory.cc ('k') | src/inspector/debugger_script_externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/debugger-script.js
diff --git a/src/inspector/debugger-script.js b/src/inspector/debugger-script.js
index 4ddc9a7d21209514e13e74aaaec080cf0cfbcf05..22a5303cd69fdc8e9931145d1d60241086ee4dc6 100644
--- a/src/inspector/debugger-script.js
+++ b/src/inspector/debugger-script.js
@@ -103,31 +103,6 @@ DebuggerScript.getGeneratorScopes = function(gen)
/**
* @param {!ExecutionState} execState
- * @param {!BreakpointInfo} info
- * @return {string|undefined}
- */
-DebuggerScript.setBreakpoint = function(execState, info)
-{
- var breakId = Debug.setScriptBreakPointById(info.sourceID, info.lineNumber, info.columnNumber, info.condition, undefined, Debug.BreakPositionAlignment.Statement);
- var locations = Debug.findBreakPointActualLocations(breakId);
- if (!locations.length)
- return undefined;
- info.lineNumber = locations[0].line;
- info.columnNumber = locations[0].column;
- return breakId.toString();
-}
-
-/**
- * @param {!ExecutionState} execState
- * @param {!{breakpointId: number}} info
- */
-DebuggerScript.removeBreakpoint = function(execState, info)
-{
- Debug.findBreakPoint(info.breakpointId, true);
-}
-
-/**
- * @param {!ExecutionState} execState
* @param {number} limit
* @return {!Array<!JavaScriptCallFrame>}
*/
@@ -178,31 +153,6 @@ DebuggerScript.liveEditScriptSource = function(scriptId, newSource, preview)
}
}
-/**
- * @param {!ExecutionState} execState
- */
-DebuggerScript.clearBreakpoints = function(execState)
-{
- Debug.clearAllBreakPoints();
-}
-
-/**
- * @param {!Array<!BreakPoint>|undefined} breakpoints
- */
-DebuggerScript.getBreakpointNumbers = function(breakpoints)
-{
- var numbers = [];
- if (!breakpoints)
- return numbers;
-
- for (var i = 0; i < breakpoints.length; i++) {
- var breakpoint = breakpoints[i];
- var scriptBreakPoint = breakpoint.script_break_point();
- numbers.push(scriptBreakPoint ? scriptBreakPoint.number() : breakpoint.number());
- }
- return numbers;
-}
-
// NOTE: This function is performance critical, as it can be run on every
// statement that generates an async event (like addEventListener) to support
// asynchronous call stacks. Thus, when possible, initialize the data lazily.
« no previous file with comments | « src/factory.cc ('k') | src/inspector/debugger_script_externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698