Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Side by Side Diff: src/objects-debug.cc

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added a test, ready for review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 1245 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 } 1256 }
1257 1257
1258 1258
1259 void DebugInfo::DebugInfoVerify() { 1259 void DebugInfo::DebugInfoVerify() {
1260 CHECK(IsDebugInfo()); 1260 CHECK(IsDebugInfo());
1261 VerifyPointer(shared()); 1261 VerifyPointer(shared());
1262 VerifyPointer(debug_bytecode_array()); 1262 VerifyPointer(debug_bytecode_array());
1263 VerifyPointer(break_points()); 1263 VerifyPointer(break_points());
1264 } 1264 }
1265 1265
1266 void BreakPoint::BreakPointVerify() {
1267 CHECK(IsBreakPoint());
1268 VerifyPointer(condition());
Yang 2017/02/15 13:21:10 Let's add a check that condition is a string.
kozy 2017/02/15 16:21:33 Done.
1269 VerifyPointer(data());
1270 }
1266 1271
1267 void BreakPointInfo::BreakPointInfoVerify() { 1272 void BreakPointInfo::BreakPointInfoVerify() {
1268 CHECK(IsBreakPointInfo()); 1273 CHECK(IsBreakPointInfo());
1269 VerifyPointer(break_point_objects()); 1274 VerifyPointer(break_point_objects());
1270 } 1275 }
1271 #endif // VERIFY_HEAP 1276 #endif // VERIFY_HEAP
1272 1277
1273 #ifdef DEBUG 1278 #ifdef DEBUG
1274 1279
1275 void JSObject::IncrementSpillStatistics(SpillInformation* info) { 1280 void JSObject::IncrementSpillStatistics(SpillInformation* info) {
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1557 1562
1558 // Both are done at the same time. 1563 // Both are done at the same time.
1559 CHECK_EQ(new_it.done(), old_it.done()); 1564 CHECK_EQ(new_it.done(), old_it.done());
1560 } 1565 }
1561 1566
1562 1567
1563 #endif // DEBUG 1568 #endif // DEBUG
1564 1569
1565 } // namespace internal 1570 } // namespace internal
1566 } // namespace v8 1571 } // namespace v8
OLDNEW
« src/debug/debug.cc ('K') | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698