[inspector] migrate set/remove BreakPoint to debug-interface.h

src/debug/debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug.h"
 
 #include <memory>
 
 #include "src/api.h"
 #include "src/arguments.h"
@@ skipping 609 matching lines @@
   Handle<Object> undefined = isolate_->factory()->undefined_value();
   MaybeHandle<Object> maybe_exception;
   return Execution::TryCall(isolate_, fun, undefined, argc, args,
                             Execution::MessageHandling::kReport,
                             &maybe_exception);
 }
 
 
 // Check whether a single break point object is triggered.
 bool Debug::CheckBreakPoint(Handle<Object> break_point_object) {
-  Factory* factory = isolate_->factory();
-  HandleScope scope(isolate_);
+  if (break_point_object->IsBreakPoint()) {
+    Handle<BreakPoint> break_point =
+        Handle<BreakPoint>::cast(break_point_object);
+    if (!break_point->condition()->IsString()) return true;
+    Handle<String> condition(String::cast(break_point->condition()));
+    Handle<Object> result;
+    if (!DebugEvaluate::Local(isolate_, break_frame_id(),
+                              /* inlined_jsframe_index */ 0, condition, false)

[Yang, 2017/02/15 13:21:10]

0 is wrong. If you have the situation where f calls g, and g calls h, and
everything is inlined into one frame, f has the index 0, g has the index 1, h
has the index 2.

It's probably easiest to pass in -1 (as a suitably named constant), and have the
FrameInspector the FrameSummary::GetTop() as frame summary for that case.

[kozy, 2017/02/15 16:21:33]

I thought that when we call CheckBreakpoint on top of stack trace we have
deoptimized frame and all inlined frames are stored separately in this case.
Done.

[Yang, 2017/02/15 16:32:23]

Ah yes you are right! Can you add a comment about this?

[kozy, 2017/02/15 16:42:33]

Added.

+             .ToHandle(&result)) {
+      if (isolate_->has_pending_exception()) {
+        isolate_->clear_pending_exception();
+      }
+      return false;
+    }
+    return result->IsTrue(isolate_);
+  }
 
   // Ignore check if break point object is not a JSObject.

[Yang, 2017/02/15 13:21:10]

Can you add a TODO to remove the code below because this is just for the debug
context?

[kozy, 2017/02/15 16:21:33]

Done.

   if (!break_point_object->IsJSObject()) return true;
 
   // Get the break id as an object.
-  Handle<Object> break_id = factory->NewNumberFromInt(Debug::break_id());
+  Handle<Object> break_id =
+      isolate_->factory()->NewNumberFromInt(Debug::break_id());
 
   // Call IsBreakPointTriggered.
   Handle<Object> argv[] = { break_id, break_point_object };
   Handle<Object> result;
   if (!CallFunction("IsBreakPointTriggered", arraysize(argv), argv)
            .ToHandle(&result)) {
     return false;
   }
 
   // Return whether the break point is triggered.
@@ skipping 1765 matching lines @@
     isolate_->Throw(*isolate_->factory()->NewEvalError(
         MessageTemplate::kNoSideEffectDebugEvaluate));
   }
   isolate_->set_needs_side_effect_check(old_needs_side_effect_check_);
   isolate_->debug()->UpdateHookOnFunctionCall();
   isolate_->debug()->side_effect_check_failed_ = false;
 }
 
 }  // namespace internal
 }  // namespace v8