Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: src/inspector/v8-debugger-script.h

Issue 2685163006: [inspector] migrate set/remove BreakPoint to debug-interface.h (Closed)
Patch Set: added comment about inlined jsframe index Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Google Inc. All rights reserved. 3 * Copyright (C) 2010 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 virtual void setSourceMappingURL(const String16&) = 0; 73 virtual void setSourceMappingURL(const String16&) = 0;
74 virtual void setSource(v8::Local<v8::String> source) { 74 virtual void setSource(v8::Local<v8::String> source) {
75 m_source = toProtocolString(source); 75 m_source = toProtocolString(source);
76 } 76 }
77 77
78 virtual bool getPossibleBreakpoints( 78 virtual bool getPossibleBreakpoints(
79 const v8::debug::Location& start, const v8::debug::Location& end, 79 const v8::debug::Location& start, const v8::debug::Location& end,
80 std::vector<v8::debug::Location>* locations) = 0; 80 std::vector<v8::debug::Location>* locations) = 0;
81 virtual void resetBlackboxedStateCache() = 0; 81 virtual void resetBlackboxedStateCache() = 0;
82 82
83 v8::debug::Location setBreakpoint(
84 const v8::debug::Location& location,
85 v8::Local<v8::debug::BreakPoint> breakPoint);
86
83 protected: 87 protected:
88 virtual v8::Local<v8::debug::Script> script() = 0;
89
84 V8DebuggerScript(v8::Isolate*, String16 id, String16 url); 90 V8DebuggerScript(v8::Isolate*, String16 id, String16 url);
85 91
86 String16 m_id; 92 String16 m_id;
87 String16 m_url; 93 String16 m_url;
88 String16 m_sourceURL; 94 String16 m_sourceURL;
89 String16 m_source; 95 String16 m_source;
90 mutable String16 m_hash; 96 mutable String16 m_hash;
91 int m_startLine = 0; 97 int m_startLine = 0;
92 int m_startColumn = 0; 98 int m_startColumn = 0;
93 int m_endLine = 0; 99 int m_endLine = 0;
94 int m_endColumn = 0; 100 int m_endColumn = 0;
95 int m_executionContextId = 0; 101 int m_executionContextId = 0;
96 102
97 v8::Isolate* m_isolate; 103 v8::Isolate* m_isolate;
98 104
99 private: 105 private:
100 DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript); 106 DISALLOW_COPY_AND_ASSIGN(V8DebuggerScript);
101 }; 107 };
102 108
103 } // namespace v8_inspector 109 } // namespace v8_inspector
104 110
105 #endif // V8_INSPECTOR_V8DEBUGGERSCRIPT_H_ 111 #endif // V8_INSPECTOR_V8DEBUGGERSCRIPT_H_
OLDNEW
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-debugger-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698