Make OAuth2TokenService and subclasses take delegate by unique_ptr

chrome/browser/chromeos/settings/device_oauth2_token_service_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service.h"
 
 #include <stdint.h>
 
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
@@ skipping 113 matching lines @@
     TestingBrowserProcess::GetGlobal()->ShutdownBrowserPolicyConnector();
     content::BrowserThread::GetBlockingPool()->FlushForTesting();
     DeviceSettingsService::Get()->UnsetSessionManager();
     DeviceSettingsService::Shutdown();
     SystemSaltGetter::Shutdown();
     DBusThreadManager::Shutdown();
     base::RunLoop().RunUntilIdle();
   }
 
   void CreateService() {
-    DeviceOAuth2TokenServiceDelegate* delegate =
-        new DeviceOAuth2TokenServiceDelegate(request_context_getter_.get(),
-                                             scoped_testing_local_state_.Get());
+    auto delegate = base::MakeUnique<DeviceOAuth2TokenServiceDelegate>(
+        request_context_getter_.get(), scoped_testing_local_state_.Get());
     delegate->max_refresh_token_validation_retries_ = 0;
-    oauth2_service_.reset(new DeviceOAuth2TokenService(delegate));
+    oauth2_service_.reset(new DeviceOAuth2TokenService(std::move(delegate)));

[msarda, 2017/02/10 09:21:22]

Optional: Consider using MakeUnique.

[bsazonov, 2017/02/10 10:41:50]

The DeviceOAuth2TokenService ctor is private, so MakeUnique won't compile. There
are some workarounds for it, but they are outside of this CL's scope.

     oauth2_service_->set_max_authorization_token_fetch_retries_for_testing(0);
   }
 
   // Utility method to set a value in Local State for the device refresh token
   // (it must have a non-empty value or it won't be used).
   void SetDeviceRefreshTokenInLocalState(const std::string& refresh_token) {
     scoped_testing_local_state_.Get()->SetUserPref(
         prefs::kDeviceRobotAnyApiRefreshToken,
         new base::StringValue(refresh_token));
   }
@@ skipping 324 matching lines @@
   // Also make the robot account ID available. Verify that the token is
   // announced now.
   EXPECT_CALL(observer, OnRefreshTokenAvailable("robot@example.com"));
   SetRobotAccountId("robot@example.com");
   testing::Mock::VerifyAndClearExpectations(&observer);
 
   oauth2_service_->RemoveObserver(&observer);
 }
 
 }  // namespace chromeos