third_party/WebKit/Source/core/svg/SVGGElement.cpp - Issue 2685113002: Cleanup SVGElement::layoutObjectIsNeeded.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGGElement.cpp

Issue 2685113002: Cleanup SVGElement::layoutObjectIsNeeded. (Closed)

Patch Set: Preserving behavior Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGSVGElement.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 return new LayoutSVGHiddenContainer(this);	42 return new LayoutSVGHiddenContainer(this);

43	43

44 return new LayoutSVGTransformableContainer(this);	44 return new LayoutSVGTransformableContainer(this);

45 }	45 }

46	46

47 bool SVGGElement::layoutObjectIsNeeded(const ComputedStyle&) {	47 bool SVGGElement::layoutObjectIsNeeded(const ComputedStyle&) {

48 // Unlike SVGElement::layoutObjectIsNeeded(), we still create layoutObjects,	48 // Unlike SVGElement::layoutObjectIsNeeded(), we still create layoutObjects,

49 // even if display is set to 'none' - which is special to SVG <g> container	49 // even if display is set to 'none' - which is special to SVG <g> container

50 // elements.	50 // elements.

51 return parentOrShadowHostElement() &&	51 return parentOrShadowHostElement() &&

52 parentOrShadowHostElement()->isSVGElement();	52 parentOrShadowHostElement()->isSVGElement() && isValid();

53 }	53 }

54	54

55 } // namespace blink	55 } // namespace blink

OLD	NEW