Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: components/browser_watcher/stability_report.proto

Issue 2685053003: Switch stability reports to use the crashed version's details (Closed)
Patch Set: Missing BUILD dependencies Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_watcher/stability_report.proto
diff --git a/components/browser_watcher/stability_report.proto b/components/browser_watcher/stability_report.proto
index 72c8fc20c1bb15452276888be525d1d8eda3b061..abb857fb66d34d93e3cffadc34f504b803514380 100644
--- a/components/browser_watcher/stability_report.proto
+++ b/components/browser_watcher/stability_report.proto
@@ -78,7 +78,7 @@ message TypedValue {
}
// An activity represents information about something of interest on a thread.
-// Next id: 10
+// Next id: 11
message Activity {
enum Type {
UNKNOWN = 0;
@@ -116,6 +116,8 @@ message Activity {
// A unique identifier for a process.
optional int64 process_id = 8;
+ // Tag id 10 is reserved.
bcwhite 2017/02/13 13:16:59 Place after #9. What is it reserved for?
manzagop (departed) 2017/02/13 17:07:45 It's for augmenting the report with symbolized inf
bcwhite 2017/02/13 18:35:07 Please add that to the comment. And move it after
manzagop (departed) 2017/02/13 19:22:33 Expanded on the comment, but purposefully remainin
bcwhite 2017/02/14 15:18:16 Acknowledged.
+
// A key-value store.
map<string, TypedValue> user_data = 9;
}

Powered by Google App Engine
This is Rietveld 408576698