Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: components/browser_watcher/postmortem_minidump_writer.h

Issue 2685053003: Switch stability reports to use the crashed version's details (Closed)
Patch Set: Merge Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/BUILD.gn ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/postmortem_minidump_writer.h
diff --git a/components/browser_watcher/postmortem_minidump_writer.h b/components/browser_watcher/postmortem_minidump_writer.h
index 28758f84a68a326124ecfa97447c0b7c2e7b9217..15079aee9320e2103135d9619c028af7fe85ae43 100644
--- a/components/browser_watcher/postmortem_minidump_writer.h
+++ b/components/browser_watcher/postmortem_minidump_writer.h
@@ -15,33 +15,15 @@
namespace browser_watcher {
-// Minidump information required by the Crashpad reporter.
-struct MinidumpInfo {
- MinidumpInfo();
- ~MinidumpInfo();
-
- // Client and report identifiers, from the Crashpad database.
- crashpad::UUID client_id;
- crashpad::UUID report_id;
-
- // Product name, version number and channel name from the executable's version
- // resource.
- std::string product_name;
- std::string version_number;
- std::string channel_name;
-
- // The platform identifier (e.g. "Win32" or "Win64").
- std::string platform;
-};
-
// Write to |minidump_file| a minimal minidump that wraps |report|. Returns
// true on success, false otherwise.
// Note: the caller owns |minidump_file| and is responsible for keeping it valid
// for this function's duration. |minidump_file| is expected to be empty
// and a binary stream.
bool WritePostmortemDump(base::PlatformFile minidump_file,
- const StabilityReport& report,
- const MinidumpInfo& minidump_info);
+ const crashpad::UUID& client_id,
+ const crashpad::UUID& report_id,
+ StabilityReport* report);
} // namespace browser_watcher
« no previous file with comments | « components/browser_watcher/BUILD.gn ('k') | components/browser_watcher/postmortem_minidump_writer_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698