Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: content/test/test_render_view_host.h

Issue 2684993011: Revert of Make TestRenderWidgetHostView::Show/Hide call through to RWHI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crash
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/test_renderer_host.h ('k') | content/test/test_render_view_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_render_view_host.h
diff --git a/content/test/test_render_view_host.h b/content/test/test_render_view_host.h
index 284f1644ec2495787e2f21386a76c87c8a301bc0..02e008f48c0ae7dcf9dd6f33088bdde5ba0ae2da 100644
--- a/content/test/test_render_view_host.h
+++ b/content/test/test_render_view_host.h
@@ -54,7 +54,8 @@
// TestRenderWidgetHostView ----------------------------------------------------
-// Subclass the RenderViewHost's view.
+// Subclass the RenderViewHost's view so that we can call Show(), etc.,
+// without having side-effects.
class TestRenderWidgetHostView : public RenderWidgetHostViewBase {
public:
explicit TestRenderWidgetHostView(RenderWidgetHost* rwh);
@@ -115,6 +116,7 @@
void UnlockMouse() override;
cc::FrameSinkId GetFrameSinkId() override;
+ bool is_showing() const { return is_showing_; }
bool is_occluded() const { return is_occluded_; }
bool did_swap_compositor_frame() const { return did_swap_compositor_frame_; }
@@ -123,6 +125,7 @@
cc::FrameSinkId frame_sink_id_;
private:
+ bool is_showing_;
bool is_occluded_;
bool did_swap_compositor_frame_;
ui::DummyTextInputClient text_input_client_;
@@ -183,6 +186,8 @@
// RenderViewHostTester implementation. Note that CreateRenderView
// is not specified since it is synonymous with the one from
// RenderViewHostImpl, see below.
+ void SimulateWasHidden() override;
+ void SimulateWasShown() override;
WebPreferences TestComputeWebkitPrefs() override;
void TestOnUpdateStateWithFile(const base::FilePath& file_path);
« no previous file with comments | « content/public/test/test_renderer_host.h ('k') | content/test/test_render_view_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698