ui/views/controls/menu/menu_controller.cc - Issue 2684993009: Stop MenuItemView From Directly Caching MenuController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 2684993009: Stop MenuItemView From Directly Caching MenuController (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller.cc

diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc

index 37db59dfd9313ef7ac30b9dbc1b132207cbe56ea..335945f284ed025510dfe538b0f75ded3e3421d5 100644

--- a/ui/views/controls/menu/menu_controller.cc

+++ b/ui/views/controls/menu/menu_controller.cc

@@ -1554,7 +1554,7 @@ bool MenuController::ShowSiblingMenu(SubmenuView* source,

alt_menu->PrepareForRun(

false, has_mnemonics,

source->GetMenuItem()->GetRootMenuItem()->show_mnemonics_);

- alt_menu->controller_ = this;

+ alt_menu->controller_ = AsWeakPtr();

SetSelection(alt_menu, SELECTION_OPEN_SUBMENU | SELECTION_UPDATE_IMMEDIATELY);

return true;

}

« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller_unittest.cc » ('j') | no next file with comments »