Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: components/ntp_snippets/offline_pages/offline_pages_test_utils.cc

Issue 2684973014: Only show Last N Pages in the UI when the corresponding tab is visible. (Closed)
Patch Set: Move impl out Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
diff --git a/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc b/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
index 81d84f73454fae0e2708f74cf380a688dfec5651..22a406ad968bd53cdef382a006d9d663ca789b39 100644
--- a/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
+++ b/components/ntp_snippets/offline_pages/offline_pages_test_utils.cc
@@ -59,16 +59,22 @@ void FakeOfflinePageModel::set_is_loaded(bool value) {
is_loaded_ = value;
}
-OfflinePageItem CreateDummyOfflinePageItem(int id,
- const std::string& name_space) {
+OfflinePageItem CreateDummyOfflinePageItem(
+ int id,
+ const offline_pages::ClientId& client_id) {
std::string id_string = base::IntToString(id);
return OfflinePageItem(
- GURL("http://dummy.com/" + id_string), id,
- ClientId(name_space, base::GenerateGUID()),
+ GURL("http://dummy.com/" + id_string), id, client_id,
base::FilePath::FromUTF8Unsafe("some/folder/test" + id_string + ".mhtml"),
0, base::Time::Now());
}
+OfflinePageItem CreateDummyOfflinePageItem(int id,
+ const std::string& name_space) {
+ return CreateDummyOfflinePageItem(id,
+ ClientId(name_space, base::GenerateGUID()));
+}
+
void CaptureDismissedSuggestions(
std::vector<ContentSuggestion>* captured_suggestions,
std::vector<ContentSuggestion> dismissed_suggestions) {

Powered by Google App Engine
This is Rietveld 408576698