Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc

Issue 2684973014: Only show Last N Pages in the UI when the corresponding tab is visible. (Closed)
Patch Set: Add unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
diff --git a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
index 87cc2830272571b6a1614bec43d1bf49231bf018..3532419a56a6f4b60c12f8909c83c606af34352a 100644
--- a/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
+++ b/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
@@ -42,6 +42,7 @@
#include "components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h"
#include "components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.h"
#include "components/ntp_snippets/sessions/tab_delegate_sync_adapter.h"
+#include "components/offline_pages/core/recent_tabs/recent_tabs_ui_adapter_delegate.h"
vitaliii 2017/02/15 10:12:15 Shouldn't this be in OS_ANDROID block?
dewittj 2017/02/15 19:49:44 Done.
#include "components/prefs/pref_service.h"
#include "components/safe_json/safe_json_parser.h"
#include "components/signin/core/browser/profile_oauth2_token_service.h"
@@ -58,12 +59,14 @@
#include "chrome/browser/android/chrome_feature_list.h"
#include "chrome/browser/android/ntp/ntp_snippets_launcher.h"
#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
+#include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
#include "chrome/browser/download/download_history.h"
#include "chrome/browser/download/download_service.h"
#include "chrome/browser/download/download_service_factory.h"
#include "chrome/browser/ntp_snippets/download_suggestions_provider.h"
#include "components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.h"
#include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h"
+#include "components/offline_pages/core/background/request_coordinator.h"
#include "components/offline_pages/core/offline_page_feature.h"
#include "components/offline_pages/core/offline_page_model.h"
#include "components/physical_web/data_source/physical_web_data_source.h"
@@ -72,7 +75,9 @@ using content::DownloadManager;
using ntp_snippets::PhysicalWebPageSuggestionsProvider;
using ntp_snippets::RecentTabSuggestionsProvider;
using offline_pages::OfflinePageModel;
+using offline_pages::RequestCoordinator;
using offline_pages::OfflinePageModelFactory;
+using offline_pages::RequestCoordinatorFactory;
using physical_web::PhysicalWebDataSource;
#endif // OS_ANDROID
@@ -119,10 +124,11 @@ bool IsRecentTabProviderEnabled() {
}
void RegisterRecentTabProvider(OfflinePageModel* offline_page_model,
+ RequestCoordinator* request_coordinator,
ContentSuggestionsService* service,
PrefService* pref_service) {
auto provider = base::MakeUnique<RecentTabSuggestionsProvider>(
- service, offline_page_model, pref_service);
+ service, offline_page_model, request_coordinator, pref_service);
service->RegisterProvider(std::move(provider));
}
@@ -289,6 +295,8 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
#if defined(OS_ANDROID)
OfflinePageModel* offline_page_model =
OfflinePageModelFactory::GetForBrowserContext(profile);
+ RequestCoordinator* request_coordinator =
+ RequestCoordinatorFactory::GetForBrowserContext(profile);
DownloadManager* download_manager =
content::BrowserContext::GetDownloadManager(profile);
DownloadService* download_service =
@@ -308,7 +316,8 @@ KeyedService* ContentSuggestionsServiceFactory::BuildServiceInstanceFor(
#if defined(OS_ANDROID)
if (IsRecentTabProviderEnabled()) {
- RegisterRecentTabProvider(offline_page_model, service, pref_service);
+ RegisterRecentTabProvider(offline_page_model, request_coordinator, service,
+ pref_service);
}
bool show_asset_downloads =

Powered by Google App Engine
This is Rietveld 408576698