third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html - Issue 2684973004: Remove unnecessary refreshCastButtonVisibility call

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

Issue 2684973004: Remove unnecessary refreshCastButtonVisibility call (Closed)

Patch Set: remove extra blank lines Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-button.html ('k') | third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>media controls cast button</title>	2 <title>media controls cast button</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="media-file.js"></script>	5 <script src="media-file.js"></script>

6 <script src="media-controls.js"></script>	6 <script src="media-controls.js"></script>

7 <video width="100" height="200" controls></video>	7 <video width="100" height="200" controls></video>

8 <script>	8 <script>

9 async_test(function(t) {	9 async_test(function(t) {

10 var video = document.querySelector("video");	10 var video = document.querySelector("video");

11 video.src = findMediaFile("video", "content/test");	11 video.src = findMediaFile("video", "content/test");

12	12

13 video.onloadedmetadata = t.step_func_done(function() {	13 video.onloadedmetadata = t.step_func(function() {

14 // Pretend we have a cast device	14 // Pretend we have a cast device

15 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);	15 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, true);

16	16

17 // Video should not have a cast button since the video is too narrow	17 // Video should not have a cast button since the video is too narrow

18 var button = castButton(video);	18 assert_false(isVisible(castButton(video)), "button should not be visible ");

19 assert_equals(button.style.display, "none", "button should not be visibl e");

20	19

21 // It should not have an overlay cast button too. Instead, the button	20 // It should not have an overlay cast button too. Instead, the button

22 // should appear in the overflow menu. Tested somewhere else.	21 // should appear in the overflow menu. Tested somewhere else.

23 button = overlayCastButton(video);	22 assert_false(isVisible(overlayCastButton(video)), "button should not be visible");

24 assert_equals(button.style.display, "none", "button should not be visibl e");	23

	24 // Increasing video width should show the cast button.

	25 video.width = 500;

	26 testRunner.layoutAndPaintAsyncThen(t.step_func(function() {

	27 assert_true(isVisible(castButton(video)), "button should be visible" );

	28

	29 // Decreasing video width should hide the cast button again.

	30 video.width = 100;

	31 testRunner.layoutAndPaintAsyncThen(t.step_func(function() {

	32 assert_false(isVisible(castButton(video)), "button should not be visible");

	33

	34 // If the cast device is lost, we still don't show the cast

	35 // button when the video width increases.

	36 internals.mediaPlayerRemoteRouteAvailabilityChanged(video, false );

	37 video.width = 500;

	38 testRunner.layoutAndPaintAsyncThen(t.step_func_done(function() {

	39 assert_false(isVisible(castButton(video)), "button should no t be visible");

	40 }));

	41 }));

	42 }));

25 });	43 });

26	44

27 function castButton(element) {	45 function isVisible(button) {

28 var controlID = "-internal-media-controls-cast-button";	46 var computedStyle = getComputedStyle(button);

29 var button = mediaControlsElement(internals.shadowRoot(element).firstChi ld, controlID);	47 return computedStyle.display !== "none" &&

30 if (!button)	48 computedStyle.display !== "hidden" &&

31 throw "Failed to find cast button";	49 computedStyle.visibility === "visible";

32 return button;

33 }

34

35 function overlayCastButton(element) {

36 var controlID = "-internal-media-controls-overlay-cast-button";

37 return mediaControlsElement(internals.shadowRoot(element).firstChild, co ntrolID);

38 return button

39 if (!button)

40 throw "Failed to find cast button";

41 return button;

42 }	50 }

43 });	51 });

44 </script>	52 </script>

OLD	NEW