Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: chrome/browser/first_run/first_run.cc

Issue 2684963003: Suppressing First Run bubble when viewing chrome://welcome-win10 (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run/first_run.cc
diff --git a/chrome/browser/first_run/first_run.cc b/chrome/browser/first_run/first_run.cc
index e1d7dd2e7ac41876f2ce4050e61a3354190e967b..ca397ec6eb117bfe7b4c6600a2e1b225c69a642e 100644
--- a/chrome/browser/first_run/first_run.cc
+++ b/chrome/browser/first_run/first_run.cc
@@ -342,7 +342,9 @@ bool IsOnWelcomePage(content::WebContents* contents) {
}
const GURL welcome_page(chrome::kChromeUIWelcomeURL);
- return contents->GetURL().GetWithEmptyPath() == welcome_page;
+ const GURL welcome_page_win10(chrome::kChromeUIWelcomeWin10URL);
+ const GURL current = contents->GetURL().GetWithEmptyPath();
+ return current == welcome_page || current == welcome_page_win10;
}
// Show the first run search engine bubble at the first appropriate opportunity.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698