[Kernel] Enable Kernel Isolate to use Fasta instead of DartK.

[Kernel] Enable Kernel Isolate to use Fasta instead of DartK.

We are not switching yet, but now everybody can try fasta by doing:

$ dart -DDFE_USE_FASTA=true --dfe=utils/kernel-service.dart hello.dart

Note that when using fasta we expect that patched_sdk contains platform.dill
Kernel binary containing compiled patched sdk. This file can be obtained by
doing:

$ export DART_AOT_SDK=<path-to-patched_sdk>
$ dart pkg/front_end/lib/src/fasta/bin/compile_platform.dart \
  ${DART_AOT_SDK}/platform.dill

We are also adding --use-fasta to testing script to allow end-to-end testing
of fasta (though platform.dill file needs to be generated manually prior to
running tests):

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta

Current test status:

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta
[27:34 | 100% | +12566 | - 1941]

BUG=
R=ahe@google.com, kustermann@google.com

Committed: https://github.com/dart-lang/sdk/commit/d5a11f3d340fd4c2686c1e2c7489c32d5dbb2605

[Vyacheslav Egorov (Google), 2017-02-08 13:57:49]

vegorov@google.com changed reviewers:
+ ahe@google.com, kustermann@google.com

[Vyacheslav Egorov (Google), 2017-02-08 13:57:49]

PTAL

[ahe, 2017-02-08 14:13:08]

lgtm

Thank you!

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:38: //
Nit: this comment should probably be documentation, that is, three slashes
instead of two. Also, the library declaration should come after this comment.
This way, this comment becomes the documentation for this library.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:54: import
'package:front_end/src/fasta/kernel/kernel_target.dart' show KernelSourceTarget;
Long line.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:60: const bool useFasta = const
bool.fromEnvironment('DFE_USE_FASTA') ?? false;
Don't need ?? here as "false" is the default.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:105: throw "can't deserialize
CompilationFail from ${m}";
Start with uppercase and end with a period.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:146: 
Extra line.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:166: new KernelSourceTarget(dillTarget,
uriTranslator);
Indentation.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:178: }
We need a better API for this. I think Paul and Siggi are working on that, if it
hasn't landed already.

[kustermann, 2017-02-08 15:10:41]

lgtm

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:146: 
no 2 line requirement here :)

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:162: Ticker ticker = new
Ticker(isVerbose: false);
final

Not sure what [Ticker] is but you could pass along the 'verbose' we get via
bool.fromEnvironment()?

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:163: DillTarget dillTarget = new
DillTarget(ticker, uriTranslator);
final

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:188: await batch_loader.getLoader(new
Repository(), dartOptions);
maybe run dartfmt on this file?

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:191: var errors = loader.errors;
final

[Vyacheslav Egorov (Google), 2017-02-08 15:46:19]

Thanks for the review!

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
File utils/kernel-service/kernel-service.dart (right):

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:38: //
On 2017/02/08 14:13:08, ahe wrote:
> Nit: this comment should probably be documentation, that is, three slashes
> instead of two. Also, the library declaration should come after this comment.
> This way, this comment becomes the documentation for this library.

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:54: import
'package:front_end/src/fasta/kernel/kernel_target.dart' show KernelSourceTarget;
On 2017/02/08 14:13:08, ahe wrote:
> Long line.

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:60: const bool useFasta = const
bool.fromEnvironment('DFE_USE_FASTA') ?? false;
On 2017/02/08 14:13:08, ahe wrote:
> Don't need ?? here as "false" is the default.

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:105: throw "can't deserialize
CompilationFail from ${m}";
On 2017/02/08 14:13:08, ahe wrote:
> Start with uppercase and end with a period.

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:146: 
On 2017/02/08 15:10:40, kustermann wrote:
> no 2 line requirement here :)

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:162: Ticker ticker = new
Ticker(isVerbose: false);
On 2017/02/08 15:10:41, kustermann wrote:
> final
> 
> Not sure what [Ticker] is but you could pass along the 'verbose' we get via
> bool.fromEnvironment()?

This is for Fasta own diagnostic messages. Great idea to pass down verbose!

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:163: DillTarget dillTarget = new
DillTarget(ticker, uriTranslator);
On 2017/02/08 15:10:40, kustermann wrote:
> final

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:166: new KernelSourceTarget(dillTarget,
uriTranslator);
On 2017/02/08 14:13:08, ahe wrote:
> Indentation.

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:178: }
On 2017/02/08 14:13:08, ahe wrote:
> We need a better API for this. I think Paul and Siggi are working on that, if
it
> hasn't landed already.

Yeah, they are working on this. But in the mean while we have to have something
:)

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:188: await batch_loader.getLoader(new
Repository(), dartOptions);
On 2017/02/08 15:10:41, kustermann wrote:
> maybe run dartfmt on this file?

Done.

https://codereview.chromium.org/2684943003/diff/20001/utils/kernel-service/ke...
utils/kernel-service/kernel-service.dart:191: var errors = loader.errors;
On 2017/02/08 15:10:41, kustermann wrote:
> final

Done.

[Vyacheslav Egorov (Google), 2017-02-08 15:48:38]

Description was changed from

==========
[Kernel] Enable Kernel Isolate to use Fasta instead of DartK.

We are not switching yet, but now everybody can try fasta by doing:

$ dart -DDFE_USE_FASTA=true --dfe=utils/kernel-service.dart hello.dart

Note that when using fasta we expect that patched_sdk contains platform.dill
Kernel binary containing compiled patched sdk. This file can be obtained by
doing:

$ export DART_AOT_SDK=<path-to-patched_sdk>
$ dart pkg/front_end/lib/src/fasta/bin/compile_platform.dart \
  ${DART_AOT_SDK}/platform.dill

We are also adding --use-fasta to testing script to allow end-to-end testing
of fasta (though platform.dill file needs to be generated manually prior to
running tests):

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta

Current test status:

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta
[27:34 | 100% | +12566 | - 1941]

BUG=
==========

to

==========
[Kernel] Enable Kernel Isolate to use Fasta instead of DartK.

We are not switching yet, but now everybody can try fasta by doing:

$ dart -DDFE_USE_FASTA=true --dfe=utils/kernel-service.dart hello.dart

Note that when using fasta we expect that patched_sdk contains platform.dill
Kernel binary containing compiled patched sdk. This file can be obtained by
doing:

$ export DART_AOT_SDK=<path-to-patched_sdk>
$ dart pkg/front_end/lib/src/fasta/bin/compile_platform.dart \
  ${DART_AOT_SDK}/platform.dill

We are also adding --use-fasta to testing script to allow end-to-end testing
of fasta (though platform.dill file needs to be generated manually prior to
running tests):

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta

Current test status:

$ tools/test.py -c dartk -m release -a x64 --nobatch --use-fasta
[27:34 | 100% | +12566 | - 1941]

BUG=
R=ahe@google.com, kustermann@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d5a11f3d340fd4c2686c1e2c7489c32d5dbb2605
==========

[Vyacheslav Egorov (Google), 2017-02-08 15:48:39]

Committed patchset #3 (id:40001) manually as
d5a11f3d340fd4c2686c1e2c7489c32d5dbb2605 (presubmit successful).