ios/net/cookies/cookie_store_ios.mm - Issue 2684933009: [Cronet] Fix compilation and test errors for CookieStoreIOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/net/cookies/cookie_store_ios.mm

Issue 2684933009: [Cronet] Fix compilation and test errors for CookieStoreIOS. (Closed)

Patch Set: CookieStoreIOS::SystemCookiesAllowed should be true unless policy is 'Never'. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/net/cookies/cookie_store_ios.mm

diff --git a/ios/net/cookies/cookie_store_ios.mm b/ios/net/cookies/cookie_store_ios.mm

index 68d11feb69cc6eb2d9b38b7ddbe2df073d786b31..8e9e9ea2c4ce0d4b66dd3589f138341006f6a679 100644

--- a/ios/net/cookies/cookie_store_ios.mm

+++ b/ios/net/cookies/cookie_store_ios.mm

@@ -591,8 +591,7 @@ void CookieStoreIOS::ClearSystemStore() {

bool CookieStoreIOS::SystemCookiesAllowed() {

DCHECK(thread_checker_.CalledOnValidThread());

- return [system_store_ cookieAcceptPolicy] ==

- NSHTTPCookieAcceptPolicyAlways;

+ return [system_store_ cookieAcceptPolicy] != NSHTTPCookieAcceptPolicyNever;

Eugene But (OOO till 7-30) 2017/02/10 00:17:01 This will return YES if 3rd party cookies are bloc

lilyhoughton 2017/02/10 16:41:18 What is the specific issue that this change fixes?

mef 2017/02/10 17:04:59 Done.

mef 2017/02/10 17:04:59 It broke Cronet cookie tests. I've entered crbug.

}

void CookieStoreIOS::WriteToCookieMonster(NSArray* system_cookies) {

« no previous file with comments | « ios/crnet/crnet_environment.mm ('k') | no next file » | no next file with comments »