Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 268493004: [NaCl SDK] Add ppapi_stub for bionic (Closed)

Created:
6 years, 7 months ago by noelallen1
Modified:
6 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK} Add ppapi_stub for bionic Bionic uses a different loader which requires a different ppapi_stub. This implementaion is for the experimental bionic build only. BUG=none R=binji@chromium.org See related issue to re-merge with GYP/GN https://code.google.com/p/chromium/issues/detail?id=368779

Patch Set 1 #

Patch Set 2 : Remove unneeded symbol 'dl_irt_ptr'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -3 lines) Patch
A native_client_sdk/src/libraries/ppapi_stub/library.dsc View 1 chunk +19 lines, -0 lines 0 comments Download
A + native_client_sdk/src/libraries/ppapi_stub/main.c View 1 chunk +4 lines, -3 lines 0 comments Download
A native_client_sdk/src/libraries/ppapi_stub/ppapi_main.c View 1 1 chunk +110 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
noelallen1
ptal Based on src/ppapi/native_client/src/untrusted/irt_stub
6 years, 7 months ago (2014-04-30 18:50:40 UTC) #1
Sam Clegg
On 2014/04/30 18:50:40, noelallen1 wrote: > ptal > > Based on src/ppapi/native_client/src/untrusted/irt_stub Why use a ...
6 years, 7 months ago (2014-04-30 19:05:56 UTC) #2
noelallen1
On 2014/04/30 19:05:56, Sam Clegg wrote: > On 2014/04/30 18:50:40, noelallen1 wrote: > > ptal ...
6 years, 7 months ago (2014-04-30 19:55:49 UTC) #3
binji
On 2014/04/30 19:55:49, noelallen1 wrote: > On 2014/04/30 19:05:56, Sam Clegg wrote: > > On ...
6 years, 7 months ago (2014-04-30 23:54:36 UTC) #4
noelallen1
Several reasons, the version in chrome: uses chrome relative headers and include paths. can affect ...
6 years, 7 months ago (2014-05-01 16:36:05 UTC) #5
binji
6 years, 7 months ago (2014-05-01 16:49:43 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698