Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3842)

Unified Diff: chrome/browser/permissions/permission_queue_controller.cc

Issue 2684913002: Add UMA for recording embargo reasons and autoblocker interactions. (Closed)
Patch Set: Add android embargo tracking. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_queue_controller.cc
diff --git a/chrome/browser/permissions/permission_queue_controller.cc b/chrome/browser/permissions/permission_queue_controller.cc
index 4a126626edb7195011b91c3f910c805f7e4c6884..90b17a3a9cc64c88cb87f94da47d6c1b4e380417 100644
--- a/chrome/browser/permissions/permission_queue_controller.cc
+++ b/chrome/browser/permissions/permission_queue_controller.cc
@@ -228,16 +228,28 @@ void PermissionQueueController::OnPermissionSet(const PermissionRequestID& id,
requesting_frame, profile_);
PermissionUmaUtil::RecordPermissionPromptAccepted(request_type,
gesture_type);
+ PermissionUmaUtil::RecordPermissionEmbargoStatus(
+ PermissionEmbargoStatus::NOT_EMBARGOED);
break;
case DENIED:
PermissionUmaUtil::PermissionDenied(permission_type_, gesture_type,
requesting_frame, profile_);
PermissionUmaUtil::RecordPermissionPromptDenied(request_type,
gesture_type);
+ PermissionUmaUtil::RecordPermissionEmbargoStatus(
+ PermissionEmbargoStatus::NOT_EMBARGOED);
break;
case DISMISSED:
PermissionUmaUtil::PermissionDismissed(permission_type_, gesture_type,
requesting_frame, profile_);
+ if (PermissionDecisionAutoBlocker::GetForProfile(profile_)
+ ->RecordDismissAndEmbargo(requesting_origin, permission_type_)) {
raymes 2017/02/09 05:46:39 Unfortunately this is going to be untested code :(
dominickn 2017/02/10 03:12:33 We could look at adding Java side tests for this.
+ PermissionUmaUtil::RecordPermissionEmbargoStatus(
+ PermissionEmbargoStatus::REPEATED_DISMISSALS);
+ } else {
+ PermissionUmaUtil::RecordPermissionEmbargoStatus(
+ PermissionEmbargoStatus::NOT_EMBARGOED);
+ }
break;
default:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698