Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4484)

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2684913002: Add UMA for recording embargo reasons and autoblocker interactions. (Closed)
Patch Set: Review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_request_impl.cc
diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc
index 62cf0d94430c8aaffbca3926758b8b7f1da7fb54..44fcd06cc4020bb48d909d79dceaf19727e392a3 100644
--- a/chrome/browser/permissions/permission_request_impl.cc
+++ b/chrome/browser/permissions/permission_request_impl.cc
@@ -38,6 +38,8 @@ PermissionRequestImpl::~PermissionRequestImpl() {
if (!action_taken_) {
PermissionUmaUtil::PermissionIgnored(permission_type_, GetGestureType(),
request_origin_, profile_);
+ PermissionUmaUtil::RecordPermissionEmbargoReason(
+ PermissionEmbargoReason::NOT_EMBARGOED);
dominickn 2017/02/09 00:54:11 This also needs to be called in PermissionInfoBarD
meredithl 2017/02/09 02:58:28 Acknowledged.
}
}

Powered by Google App Engine
This is Rietveld 408576698