Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4941)

Unified Diff: chrome/test/data/webui/settings/metrics_reporting_tests.js

Issue 2684853003: MD Settings: change how tap is handled on custom toggle rows (Closed)
Patch Set: todo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/metrics_reporting_tests.js
diff --git a/chrome/test/data/webui/settings/metrics_reporting_tests.js b/chrome/test/data/webui/settings/metrics_reporting_tests.js
index de2f12c0040dcc342e0d04d0df662f988af121b3..e9ef617d5ef001b2b36b0d1ea3241c1a3a141ddb 100644
--- a/chrome/test/data/webui/settings/metrics_reporting_tests.js
+++ b/chrome/test/data/webui/settings/metrics_reporting_tests.js
@@ -24,8 +24,8 @@ suite('metrics reporting', function() {
var control = page.$.metricsReportingControl;
assertEquals(testBrowserProxy.metricsReporting.enabled, control.checked);
- var indicatorVisible = !!page.$$('#indicator');
- assertEquals(testBrowserProxy.metricsReporting.managed, indicatorVisible);
+ assertEquals(testBrowserProxy.metricsReporting.managed,
+ !!control.pref.controlledBy);
var changedMetrics = {
enabled: !testBrowserProxy.metricsReporting.enabled,
@@ -35,13 +35,16 @@ suite('metrics reporting', function() {
Polymer.dom.flush();
assertEquals(changedMetrics.enabled, control.checked);
- indicatorVisible = !!page.$$('#indicator');
- assertEquals(changedMetrics.managed, indicatorVisible);
+ assertEquals(changedMetrics.managed, !!control.pref.controlledBy);
var toggled = !changedMetrics.enabled;
+ control.checked = toggled;
+ control.notifyChangedByUserInteraction();
- MockInteractions.tap(control);
- return testBrowserProxy.whenCalled('setMetricsReportingEnabled', toggled);
+ return testBrowserProxy.whenCalled('setMetricsReportingEnabled').then(
+ function(enabled) {
+ assertEquals(toggled, enabled);
+ });
});
});
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698