chrome/browser/resources/settings/controls/settings_toggle_button.js - Issue 2684853003: MD Settings: change how tap is handled on custom toggle rows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/settings_toggle_button.js

Issue 2684853003: MD Settings: change how tap is handled on custom toggle rows (Closed)

Patch Set: todo Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/controls/settings_toggle_button.html ('k') | chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/settings_toggle_button.js

diff --git a/chrome/browser/resources/settings/controls/settings_toggle_button.js b/chrome/browser/resources/settings/controls/settings_toggle_button.js

index fcfa247e202cd4ecca207b6f3310ec22cf511d36..1352bccfeadf21ee4242a8d4dfe60e9c1e330d12 100644

--- a/chrome/browser/resources/settings/controls/settings_toggle_button.js

+++ b/chrome/browser/resources/settings/controls/settings_toggle_button.js

@@ -20,7 +20,10 @@ Polymer({

/** @private */

onLabelWrapperTap_: function() {

- if (!this.controlDisabled_())

- this.checked = !this.checked;

+ if (this.controlDisabled_())

+ return;

+ this.checked = !this.checked;

+ this.notifyChangedByUserInteraction();

});