Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6548)

Unified Diff: chrome/browser/resources/settings/controls/settings_checkbox.html

Issue 2684853003: MD Settings: change how tap is handled on custom toggle rows (Closed)
Patch Set: todo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_checkbox.html
diff --git a/chrome/browser/resources/settings/controls/settings_checkbox.html b/chrome/browser/resources/settings/controls/settings_checkbox.html
index 9f4ae7b9ad5a0ddd563984dd3a9b0b2b9f93ea2c..5bc7cf31861045029be912c324c3789f83dd6bf4 100644
--- a/chrome/browser/resources/settings/controls/settings_checkbox.html
+++ b/chrome/browser/resources/settings/controls/settings_checkbox.html
@@ -30,6 +30,8 @@
}
</style>
<div id="outerRow" noSubLabel$="[[!subLabel]]">
+ <!-- TODO(dbeam): should we be calling notifyChangedByUserInteraction
+ somewhere here like we do for settings-toggle-button? -->
<paper-checkbox id="checkbox" checked="{{checked}}"
disabled="[[controlDisabled_(disabled, pref)]]">
<div>[[label]] <content></content></div>

Powered by Google App Engine
This is Rietveld 408576698