MD Settings: change how tap is handled on custom toggle rows

chrome/test/data/webui/settings/metrics_reporting_tests.js

Index: chrome/test/data/webui/settings/metrics_reporting_tests.js
diff --git a/chrome/test/data/webui/settings/metrics_reporting_tests.js b/chrome/test/data/webui/settings/metrics_reporting_tests.js
index de2f12c0040dcc342e0d04d0df662f988af121b3..7b08b37aa20f1c093f6d844c735f3ff78547fa08 100644
--- a/chrome/test/data/webui/settings/metrics_reporting_tests.js
+++ b/chrome/test/data/webui/settings/metrics_reporting_tests.js
@@ -24,7 +24,7 @@ suite('metrics reporting', function() {
 
       var control = page.$.metricsReportingControl;
       assertEquals(testBrowserProxy.metricsReporting.enabled, control.checked);
-      var indicatorVisible = !!page.$$('#indicator');
+      var indicatorVisible = !!control.$$('cr-policy-pref-indicator');

[Dan Beam, 2017/02/09 16:07:42]

dpapad@: i'll do whatever you want here, this is one of those existing bad
examples i told you about

[dpapad, 2017/02/09 19:51:45]

Ok, perhaps add the following?
if (testBrowserProxy.metricsReporting.managed)
  assertTrue(control.$$('cr-policy-pref-indicator').isActive());

[Dan Beam, 2017/02/09 20:48:45]

that still pokes into <settings-toggle-button>'s DOM

i just used a different public interface

       assertEquals(testBrowserProxy.metricsReporting.managed, indicatorVisible);
 
       var changedMetrics = {
@@ -35,12 +35,11 @@ suite('metrics reporting', function() {
       Polymer.dom.flush();
 
       assertEquals(changedMetrics.enabled, control.checked);
-      indicatorVisible = !!page.$$('#indicator');
+      indicatorVisible = !!control.$$('cr-policy-pref-indicator');
       assertEquals(changedMetrics.managed, indicatorVisible);
 
       var toggled = !changedMetrics.enabled;
-
-      MockInteractions.tap(control);
+      control.checked = toggled;
       return testBrowserProxy.whenCalled('setMetricsReportingEnabled', toggled);

[dpapad, 2017/02/09 19:51:45]

whenCalled() only accepts one parameter. I am not sure why the previous code was
passing |toggled| here, but it seems wrong. Perhaps what it tries to do is the
following

return
testBrowserProxy.whenCalled('setMetricsReportingEnabled').then(function(arg) {
  assertEquals(control.checked, arg);
});

[Dan Beam, 2017/02/09 20:48:45]

Done. (thanks!)

     });
   });