MD Settings: change how tap is handled on custom toggle rows

chrome/test/data/webui/settings/metrics_reporting_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('metrics reporting', function() {
   /** @type {settings.TestPrivacyPageBrowserProxy} */
   var testBrowserProxy;
 
   /** @type {SettingsPrivacyPageElement} */
   var page;
 
   setup(function() {
     testBrowserProxy = new TestPrivacyPageBrowserProxy();
     settings.PrivacyPageBrowserProxyImpl.instance_ = testBrowserProxy;
     PolymerTest.clearBody();
     page = document.createElement('settings-privacy-page');
   });
 
   teardown(function() { page.remove(); });
 
   test('changes to whether metrics reporting is enabled/managed', function() {
     return testBrowserProxy.whenCalled('getMetricsReporting').then(function() {
       Polymer.dom.flush();
 
       var control = page.$.metricsReportingControl;
       assertEquals(testBrowserProxy.metricsReporting.enabled, control.checked);
-      var indicatorVisible = !!page.$$('#indicator');
+      var indicatorVisible = !!control.$$('cr-policy-pref-indicator');

[Dan Beam, 2017/02/09 16:07:42]

dpapad@: i'll do whatever you want here, this is one of those existing bad
examples i told you about

[dpapad, 2017/02/09 19:51:45]

Ok, perhaps add the following?
if (testBrowserProxy.metricsReporting.managed)
  assertTrue(control.$$('cr-policy-pref-indicator').isActive());

[Dan Beam, 2017/02/09 20:48:45]

that still pokes into <settings-toggle-button>'s DOM

i just used a different public interface

       assertEquals(testBrowserProxy.metricsReporting.managed, indicatorVisible);
 
       var changedMetrics = {
         enabled: !testBrowserProxy.metricsReporting.enabled,
         managed: !testBrowserProxy.metricsReporting.managed,
       };
       cr.webUIListenerCallback('metrics-reporting-change', changedMetrics);
       Polymer.dom.flush();
 
       assertEquals(changedMetrics.enabled, control.checked);
-      indicatorVisible = !!page.$$('#indicator');
+      indicatorVisible = !!control.$$('cr-policy-pref-indicator');
       assertEquals(changedMetrics.managed, indicatorVisible);
 
       var toggled = !changedMetrics.enabled;
-
-      MockInteractions.tap(control);
+      control.checked = toggled;
       return testBrowserProxy.whenCalled('setMetricsReportingEnabled', toggled);

[dpapad, 2017/02/09 19:51:45]

whenCalled() only accepts one parameter. I am not sure why the previous code was
passing |toggled| here, but it seems wrong. Perhaps what it tries to do is the
following

return
testBrowserProxy.whenCalled('setMetricsReportingEnabled').then(function(arg) {
  assertEquals(control.checked, arg);
});

[Dan Beam, 2017/02/09 20:48:45]

Done. (thanks!)

     });
   });
 
   test('metrics reporting restart button', function() {
     return testBrowserProxy.whenCalled('getMetricsReporting').then(function() {
       Polymer.dom.flush();
 
       // Restart button should be hidden by default (in any state).
       assertFalse(!!page.$$('#restart'));
 
@@ skipping 30 matching lines @@
       // Receiving the same values should have no effect.
        cr.webUIListenerCallback('metrics-reporting-change', {
         enabled: false,
         managed: false,
       });
       Polymer.dom.flush();
       assertTrue(!!page.$$('#restart'));
     });
   });
 });