Issue 2684833004: Eliminate commentAndMetadata() from parser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2684833004: Eliminate commentAndMetadata() from parser tests. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Eliminate commentAndMetadata() from parser tests. This allows the parser tests to be rewritten in a way that will make them easier to adapt to testing Fasta, because they no longer make assumptions about data structures passed around inside the parser. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/45fef2c2664c1d15b48a305751d8004a9d64d0a1

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -115 lines)			Patch
	M	pkg/analyzer/test/generated/parser_test.dart	View		13 chunks	+57 lines, -115 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 10 months ago (2017-02-09 00:49:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45fef2c2664c1d15b48a305751d8004a9d64d0a1 (presubmit successful).