third_party/WebKit/Source/core/layout/LayoutObject.cpp - Issue 2684833003: Disable display: contents in SVG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2684833003: Disable display: contents in SVG. (Closed)

Patch Set: Make display: contents act as an inline when it has a layout box, and ignore display: contents in S… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

index 59481168c6b51d0c2b527e6ed4771f5c0aa0e833..83ddbac407f026c4962601903fd6f71345caae1d 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp

@@ -178,7 +178,9 @@ LayoutObject* LayoutObject::createObject(Element* element,

switch (style.display()) {

case EDisplay::None:

+ return nullptr;

case EDisplay::Contents:

+ DCHECK(!element->isSVGElement());

return nullptr;

case EDisplay::Inline:

return new LayoutInline(element);