Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: trunk/src/remoting/jingle_glue/network_settings.h

Issue 268483003: Revert 267234 "New policies: enable/disable relay; port range" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_ 5 #ifndef REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_
6 #define REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_ 6 #define REMOTING_JINGLE_GLUE_NETWORK_SETTINGS_H_
7 7
8 #include <string>
9
10 #include "base/basictypes.h"
11 #include "base/logging.h"
12
13 namespace remoting { 8 namespace remoting {
14 9
15 struct NetworkSettings { 10 struct NetworkSettings {
16 11
17 // When hosts are configured with NAT traversal disabled they will 12 // When hosts are configured with NAT traversal disabled they will
18 // typically also limit their P2P ports to this range, so that 13 // typically also limit their P2P ports to this range, so that
19 // sessions may be blocked or un-blocked via firewall rules. 14 // sessions may be blocked or un-blocked via firewall rules.
20 static const int kDefaultMinPort = 12400; 15 static const int kDefaultMinPort = 12400;
21 static const int kDefaultMaxPort = 12409; 16 static const int kDefaultMaxPort = 12409;
22 17
23 enum Flags { 18 enum NatTraversalMode {
19 // Active NAT traversal using STUN and relay servers.
20 NAT_TRAVERSAL_ENABLED,
21
24 // Don't use STUN or relay servers. Accept incoming P2P connection 22 // Don't use STUN or relay servers. Accept incoming P2P connection
25 // attempts, but don't initiate any. This ensures that the peer is 23 // attempts, but don't initiate any. This ensures that the peer is
26 // on the same network. Note that connection will always fail if 24 // on the same network. Note that connection will always fail if
27 // both ends use this mode. 25 // both ends use this mode.
28 NAT_TRAVERSAL_DISABLED = 0x0, 26 NAT_TRAVERSAL_DISABLED,
29 27
30 // Allow outgoing connections, even when STUN and RELAY are not enabled. 28 // Don't use STUN or relay servers but make outgoing connections.
31 NAT_TRAVERSAL_OUTGOING = 0x1, 29 NAT_TRAVERSAL_OUTGOING,
32
33 // Active NAT traversal using STUN.
34 NAT_TRAVERSAL_STUN = 0x2,
35
36 // Allow the use of relay servers when a direct connection is not available.
37 NAT_TRAVERSAL_RELAY = 0x4,
38
39 // Active NAT traversal using STUN and relay servers.
40 NAT_TRAVERSAL_FULL = NAT_TRAVERSAL_STUN | NAT_TRAVERSAL_RELAY |
41 NAT_TRAVERSAL_OUTGOING
42 }; 30 };
43 31
44 NetworkSettings() 32 NetworkSettings()
45 : flags(NAT_TRAVERSAL_DISABLED), 33 : nat_traversal_mode(NAT_TRAVERSAL_DISABLED),
46 min_port(0),
47 max_port(0) {
48 DCHECK(!(flags & (NAT_TRAVERSAL_STUN | NAT_TRAVERSAL_RELAY)) ||
49 (flags & NAT_TRAVERSAL_OUTGOING));
50 }
51
52 explicit NetworkSettings(uint32 flags)
53 : flags(flags),
54 min_port(0), 34 min_port(0),
55 max_port(0) { 35 max_port(0) {
56 } 36 }
57 37
58 // Parse string in the form "<min_port>-<max_port>". E.g. "12400-12409". 38 explicit NetworkSettings(NatTraversalMode nat_traversal_mode)
59 // Returns true if string was parsed successfuly. 39 : nat_traversal_mode(nat_traversal_mode),
60 static bool ParsePortRange(const std::string& port_range, 40 min_port(0),
61 int* out_min_port, 41 max_port(0) {
62 int* out_max_port); 42 }
63 43
64 uint32 flags; 44 NatTraversalMode nat_traversal_mode;
65 45
66 // |min_port| and |max_port| specify range (inclusive) of ports used by 46 // |min_port| and |max_port| specify range (inclusive) of ports used by
67 // P2P sessions. Any port can be used when both values are set to 0. 47 // P2P sessions. Any port can be used when both values are set to 0.
68 int min_port; 48 int min_port;
69 int max_port; 49 int max_port;
70 }; 50 };
71 51
72 } // namespace remoting 52 } // namespace remoting
73 53
74 #endif // REMOTING_HOST_NETWORK_SETTINGS_H_ 54 #endif // REMOTING_HOST_NETWORK_SETTINGS_H_
OLDNEW
« no previous file with comments | « trunk/src/remoting/jingle_glue/chromium_port_allocator.cc ('k') | trunk/src/remoting/jingle_glue/network_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698