Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 26848011: Fix regexp interrupt test. (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : beef up test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -244 lines) Patch
M test/cctest/test-api.cc View 1 2 chunks +52 lines, -244 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
7 years, 2 months ago (2013-10-11 10:59:28 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (left): https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc#oldcode14449 test/cctest/test-api.cc:14449: class ApplyInterruptTest { this and another test in this ...
7 years, 2 months ago (2013-10-11 18:31:06 UTC) #2
Yang
On 2013/10/11 18:31:06, jochen wrote: > https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc > File test/cctest/test-api.cc (left): > > https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc#oldcode14449 > ...
7 years, 2 months ago (2013-10-14 12:04:05 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 2 months ago (2013-10-14 23:02:57 UTC) #4
Yang
7 years, 2 months ago (2013-10-15 08:06:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r17203 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698