Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 26848007: Move Navigation Timing and other various window-level objects out of page/ (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, Michael van Ouwerkerk, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Visibility:
Public.

Description

Move Navigation Timing and other various window-level objects out of page/ Navigation Timing actually has its own spec, so I moved it to its own "timing" directory. I moved a bunch of the rest of the idls in page into a new frame/ directory. I'll move Frame.h and friends in their own CL as they're included by 500+ files. BUG=305811 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -4580 lines) Patch
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DocumentLocationCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HistoryCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PerformanceEntryCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8PopStateEventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 5 chunks +47 lines, -47 lines 0 comments Download
M Source/core/dom/AddConsoleMessageTask.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/HashChangeEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PopStateEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Console.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Console.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/frame/Console.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/ConsoleBase.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/ConsoleBase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/frame/ConsoleBase.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/ConsoleTypes.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/History.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/History.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/History.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/Location.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Location.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/Navigator.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Navigator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/frame/Navigator.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/NavigatorBase.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/NavigatorID.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/NavigatorID.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/NavigatorID.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/NavigatorOnLine.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/NavigatorOnLine.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/Screen.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/frame/Screen.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/frame/Screen.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/Console.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/page/Console.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D Source/core/page/Console.idl View 1 chunk +0 lines, -34 lines 0 comments Download
D Source/core/page/ConsoleBase.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/core/page/ConsoleBase.cpp View 1 chunk +0 lines, -216 lines 0 comments Download
D Source/core/page/ConsoleBase.idl View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/page/ConsoleTypes.h View 1 chunk +0 lines, -54 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/page/History.h View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/page/History.cpp View 1 chunk +0 lines, -159 lines 0 comments Download
D Source/core/page/History.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/page/Location.h View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/core/page/Location.cpp View 1 chunk +0 lines, -269 lines 0 comments Download
D Source/core/page/Location.idl View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/page/MemoryInfo.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/page/MemoryInfo.cpp View 1 chunk +0 lines, -150 lines 0 comments Download
D Source/core/page/MemoryInfo.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/page/Navigator.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/page/Navigator.cpp View 1 chunk +0 lines, -163 lines 0 comments Download
D Source/core/page/Navigator.idl View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/core/page/NavigatorBase.h View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/page/NavigatorID.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/page/NavigatorID.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/page/NavigatorID.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/page/NavigatorOnLine.h View 1 chunk +0 lines, -48 lines 0 comments Download
D Source/core/page/NavigatorOnLine.idl View 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/page/PageConsole.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageConsole.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/page/Performance.h View 1 chunk +0 lines, -110 lines 0 comments Download
D Source/core/page/Performance.cpp View 1 chunk +0 lines, -284 lines 0 comments Download
D Source/core/page/Performance.idl View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/core/page/PerformanceEntry.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/page/PerformanceEntry.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/page/PerformanceEntry.idl View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/core/page/PerformanceMark.h View 1 chunk +0 lines, -52 lines 0 comments Download
D Source/core/page/PerformanceMark.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D Source/core/page/PerformanceMeasure.h View 1 chunk +0 lines, -51 lines 0 comments Download
D Source/core/page/PerformanceMeasure.idl View 1 chunk +0 lines, -27 lines 0 comments Download
D Source/core/page/PerformanceNavigation.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/page/PerformanceNavigation.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
D Source/core/page/PerformanceNavigation.idl View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/core/page/PerformanceResourceTiming.h View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/page/PerformanceResourceTiming.cpp View 1 chunk +0 lines, -194 lines 0 comments Download
D Source/core/page/PerformanceResourceTiming.idl View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/page/PerformanceTiming.h View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/core/page/PerformanceTiming.cpp View 1 chunk +0 lines, -356 lines 0 comments Download
D Source/core/page/PerformanceTiming.idl View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/page/PerformanceUserTiming.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/core/page/PerformanceUserTiming.cpp View 1 chunk +0 lines, -209 lines 0 comments Download
D Source/core/page/Screen.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/page/Screen.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
D Source/core/page/Screen.idl View 1 chunk +0 lines, -40 lines 0 comments Download
M Source/core/page/WorkerNavigator.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/MemoryInfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/MemoryInfo.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
A + Source/core/timing/MemoryInfo.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/Performance.h View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/core/timing/Performance.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
A + Source/core/timing/Performance.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceEntry.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceEntry.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceEntry.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceMark.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceMark.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceMeasure.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceMeasure.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceNavigation.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceNavigation.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceNavigation.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceResourceTiming.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceResourceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceResourceTiming.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceTiming.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceTiming.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/timing/PerformanceUserTiming.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/timing/PerformanceUserTiming.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerConsole.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerConsole.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/geolocation/NavigatorGeolocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/NavigatorMediaStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSocketImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/mac/WebSubstringUtil.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/MemoryInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-11 01:04:46 UTC) #1
eseidel
7 years, 2 months ago (2013-10-11 01:13:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r159402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698