Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: tests/compiler/dart2js/missing_file_test.dart

Issue 2684793002: Fix tests broken by ac6bf5926f60e81454ec5d2350a12b50d8b7481e (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/categories_test.dart ('k') | tests/compiler/dart2js/platform_consistency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/missing_file_test.dart
diff --git a/tests/compiler/dart2js/missing_file_test.dart b/tests/compiler/dart2js/missing_file_test.dart
index 96ccf0335fe7ac59cdaaded23484aa65313a125a..a2b98b270d4a88580ddc4f5c23c93f86a44c32e8 100644
--- a/tests/compiler/dart2js/missing_file_test.dart
+++ b/tests/compiler/dart2js/missing_file_test.dart
@@ -61,15 +61,23 @@ void main() {
await runTest(Uri.parse('dart:foo'), error: MessageKind.LIBRARY_NOT_FOUND);
- await runTest(Uri.parse('dart:io'),
- error: MessageKind.LIBRARY_NOT_SUPPORTED,
+ await runTest(Uri.parse('dart:_mirror_helper'),
+ error: MessageKind.INTERNAL_LIBRARY,
info: MessageKind.DISALLOWED_LIBRARY_IMPORT);
await runTest(Uri.parse('memory:bar.dart'),
error: MessageKind.LIBRARY_NOT_FOUND);
- await runTest(Uri.parse('memory:baz.dart'),
- error: MessageKind.LIBRARY_NOT_SUPPORTED,
- info: MessageKind.DISALLOWED_LIBRARY_IMPORT);
+ // Importing dart:io is temporarily allowed as a stopgap measure for the
+ // lack of config specific imports. Once that is added, this will be
+ // disallowed again.
+
+ //await runTest(Uri.parse('dart:io'),
+ // error: MessageKind.LIBRARY_NOT_SUPPORTED,
+ // info: MessageKind.DISALLOWED_LIBRARY_IMPORT);
+
+ //await runTest(Uri.parse('memory:baz.dart'),
+ // error: MessageKind.LIBRARY_NOT_SUPPORTED,
+ // info: MessageKind.DISALLOWED_LIBRARY_IMPORT);
});
}
« no previous file with comments | « tests/compiler/dart2js/categories_test.dart ('k') | tests/compiler/dart2js/platform_consistency_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698